[Kde-pim] Review Request 121460: Use QVarLengthArray in more places, instead of temporary QLists.

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121460/#review71876
-----------------------------------------------------------

Ship it!


The optimization with const static QByteArray space() can go to KDE/4.14, but the QVarLengthArray has to go to master indeed. I suggest you split to two commits, commit first to KDE/4.14, merge to master and then commit the rest to master.


akonadi/itemcreatejob.cpp
<https://git.reviewboard.kde.org/r/121460/#comment50091>

    Q_FOREACH please


- Daniel Vrátil


On Dec. 12, 2014, 4:19 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121460/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2014, 4:19 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Daniel Vrátil, Laurent Montel, and Volker Krause.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This depends on eab952bc in akonadi, to add a ImapParser::join
> that takes a QVarLengthArray. Thus, I'm not sure whether this
> can be added in stable branch, probably should go into master/kf5
> instead?
> 
> 
> Diffs
> -----
> 
>   akonadi/tagfetchjob.cpp e4fadab5b1de34e395f4b5da0b3d4300f717ab69 
>   akonadi/tagcreatejob.cpp 5e6ce18fb7bc2bc6976ce3b8aa1413e1ba82b7ce 
>   akonadi/protocolhelper_p.h b25a0e35e0aa7a254ee57cd830e8cf08430dc5ff 
>   akonadi/protocolhelper.cpp 40256e4da59fcd938bf8e02bafbf8eb6e23a54ff 
>   akonadi/itemsearchjob.cpp 03995c6c76f5dafba882340d502942a9279f6a8e 
>   akonadi/itemcreatejob.cpp 61d276ab2fc970c5540567f5cf3d5aa275b8f130 
>   akonadi/itemfetchjob.cpp a001b68d6494b80d296ddb95762afad78f87d851 
> 
> Diff: https://git.reviewboard.kde.org/r/121460/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/