[Kde-pim] Review Request 121307: Add a list of queries to the top of the query debugger.

[Laurent Montel]

> On déc. 1, 2014, 1:02 après-midi, Laurent Montel wrote:
> > akonadiconsole/querydebugger.cpp, line 86
> > <https://git.reviewboard.kde.org/r/121307/diff/1/?file=331406#file331406line86>
> >
> >     We don't extract i18n in akonadiconsole as it's a dev apps. But you can keep it. Not a problem :)
> 
> Milian Wolff wrote:
>     ah but thats nice, otherwise this couldn't go into the stable branch since it would introduce new strings. should I remove it to make sure?

it will very nice to have it in 4.14 indeed.
As there is not Message.sh it will not create problem with i18n.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121307/#review71172
-----------------------------------------------------------


On déc. 1, 2014, 12:36 après-midi, Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121307/
> -----------------------------------------------------------
> 
> (Updated déc. 1, 2014, 12:36 après-midi)
> 
> 
> Review request for KDEPIM, Daniel Vrátil and Volker Krause.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This list aggregates the query runtime and number of calls to the
> query. This is much more useful, imo, than the text view below.
> 
> Note that this patch also disables the text view by default, as it
> can easily lead to out-of-memory issues. Blindly appending lots
> of text is bound to fail, sooner or later.
> 
> 
> Diffs
> -----
> 
>   akonadiconsole/querydebugger.h 52b8a2d57501cd742dbc18516f83fe74bc7b19e0 
>   akonadiconsole/querydebugger.cpp ac1d118a0a8eebb56521f50b5fb1e9b03dec47ff 
> 
> Diff: https://git.reviewboard.kde.org/r/121307/diff/
> 
> 
> Testing
> -------
> 
> it works!
> 
> 
> File Attachments
> ----------------
> 
> screenshot of aggregation
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/12/01/a3b406a4-d03d-41dc-b198-4f2f304208cb__akonadiconsole_debugger.png
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/