[Kde-pim] Review Request 121403: Use the proper source model for the SystemTray unread count.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121403/
-----------------------------------------------------------

(Updated Dec. 9, 2014, 5:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM, Daniel Vrátil and Volker Krause.


Repository: kdepim


Description
-------

This used to iterate over mails as well (i.e. all contents of the
ETM), which is pretty useless _and_ slow. I detected this with
heaptrack, as it triggered hundred thousands of temporary allocations
of invalid Collections and those in turn allocated CachePolicies.
Turned out, the model did not check whether it can convert the source
data to a Collection, but just blindly converted it. Thus, a default
constructed Collection was returned for non-collection items. Which
is slow.

Now, we just iterate over the collection model, which will always
return valid Collections for us - much better!


Diffs
-----

  kmail/kmsystemtray.cpp dfea25d7bab8e3c354e42d997f4e0ab22c2e28dc 

Diff: https://git.reviewboard.kde.org/r/121403/diff/


Testing
-------


Thanks,

Milian Wolff

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/