[Kde-pim] Review Request 121458: Add ImapParser::join that takes a QVarLengthArray.

Milian Wolff mail at milianw.de
Fri Dec 12 15:19:43 GMT 2014



> On Dec. 12, 2014, 3:16 p.m., Daniel Vrátil wrote:
> > I assume the use of QVarLengthArray is going to be in a separate review?

Yep, see https://git.reviewboard.kde.org/r/121460/ - I forgot to publish it ;-) It's debateable whether we want this for the KDE4 branch though...


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121458/#review71867
-----------------------------------------------------------


On Dec. 12, 2014, 10:09 a.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121458/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2014, 10:09 a.m.)
> 
> 
> Review request for Akonadi, Daniel Vrátil, Laurent Montel, and Volker Krause.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> Internally, refactor the code to not do any conversions, which
> will also speed-up the code for the ImapParser::join that
> takes a QSet.
> 
> 
> Diffs
> -----
> 
>   libs/imapparser.cpp f5a7457dc49f906902876d3aaa845a2ff45ee418 
>   libs/imapparser_p.h 7f9298ac4af49df40fcf0826e796a96acaf9e71c 
> 
> Diff: https://git.reviewboard.kde.org/r/121458/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list