[Kde-pim] Review Request 121596: Separe KPeople backend and frontend headers

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121596/#review72308
-----------------------------------------------------------

Ship it!


try to avoid the typo in your commit message

- David Edmundson


On Dec. 19, 2014, 4:24 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121596/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2014, 4:24 p.m.)
> 
> 
> Review request for KDEPIM, David Edmundson and Martin Klapetek.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Separe headers between KPeople and KPeopleBackend to make it explicit what is what.
> 
> Should we even go further and make it separate libraries? This way we could even have different ABI policies...?
> 
> 
> Diffs
> -----
> 
>   src/allcontactsmonitor.h  
>   src/allcontactsmonitor.cpp  
>   src/CMakeLists.txt a98f312 
>   src/abstractpersonaction.h 982147d 
>   src/abstractpersonaction.cpp  
>   src/basepersonsdatasource.h  
>   src/basepersonsdatasource.cpp  
>   src/contactmonitor.h  
>   src/contactmonitor.cpp  
>   src/defaultcontactmonitor_p.h 03815f9 
>   src/persondata.cpp ed6d3e8 
> 
> Diff: https://git.reviewboard.kde.org/r/121596/diff/
> 
> 
> Testing
> -------
> 
> Built ktp-common-internal with it (with some obvious but small changes).
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/