[Kde-pim] Review Request 121307: Add a list of queries to the top of the query debugger.

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121307/#review71177
-----------------------------------------------------------

Ship it!


Nice idea, thanks! 

I wrote the query debugger to profile and debug queries only during some specific operations (like marking an item as read for example), long-term data collection was indeed not the intended usecase (so I did not bother with possible OOM situations).


akonadiconsole/querydebugger.cpp
<https://git.reviewboard.kde.org/r/121307/#comment49731>

    Just a nitpick: add parenthesis, or use suffix increment please, this looks like you increment the iterator instead of the member (took me a while :-)


- Daniel Vrátil


On Dec. 1, 2014, 1:36 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121307/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2014, 1:36 p.m.)
> 
> 
> Review request for KDEPIM, Daniel Vrátil and Volker Krause.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This list aggregates the query runtime and number of calls to the
> query. This is much more useful, imo, than the text view below.
> 
> Note that this patch also disables the text view by default, as it
> can easily lead to out-of-memory issues. Blindly appending lots
> of text is bound to fail, sooner or later.
> 
> 
> Diffs
> -----
> 
>   akonadiconsole/querydebugger.h 52b8a2d57501cd742dbc18516f83fe74bc7b19e0 
>   akonadiconsole/querydebugger.cpp ac1d118a0a8eebb56521f50b5fb1e9b03dec47ff 
> 
> Diff: https://git.reviewboard.kde.org/r/121307/diff/
> 
> 
> Testing
> -------
> 
> it works!
> 
> 
> File Attachments
> ----------------
> 
> screenshot of aggregation
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/12/01/a3b406a4-d03d-41dc-b198-4f2f304208cb__akonadiconsole_debugger.png
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/