[Kde-pim] Review Request 121307: Add a list of queries to the top of the query debugger.

Milian Wolff mail at milianw.de
Tue Dec 9 14:43:06 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121307/
-----------------------------------------------------------

(Updated Dec. 9, 2014, 2:43 p.m.)


Review request for KDEPIM, Daniel Vrátil and Volker Krause.


Changes
-------

removed context menu


Summary (updated)
-----------------

Add a list of queries to the top of the query debugger.


Repository: kdepim


Description (updated)
-------

This list aggregates the query runtime and number of calls to the
query. This is much more useful, imo, than the text view below.

Note that this patch also disables the text view by default, as it
can easily lead to out-of-memory issues. Blindly appending lots
of text is bound to fail, sooner or later.

The context menu is replaced by a tool button. This makes it also
possible to search in the text edit, and to copy text from it.
Much more useful.

Add average duration and aggregated totals row.

REVIEW: 121307


Diffs (updated)
-----

  akonadiconsole/querydebugger.h 52b8a2d57501cd742dbc18516f83fe74bc7b19e0 
  akonadiconsole/querydebugger.cpp ac1d118a0a8eebb56521f50b5fb1e9b03dec47ff 

Diff: https://git.reviewboard.kde.org/r/121307/diff/


Testing
-------

it works!


File Attachments
----------------

screenshot of aggregation
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/01/a3b406a4-d03d-41dc-b198-4f2f304208cb__akonadiconsole_debugger.png


Thanks,

Milian Wolff

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list