[Kde-pim] Review Request 121407: Restructure code to minimize temporary allocations.

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121407/#review71638
-----------------------------------------------------------

Ship it!


Ship It!

- Daniel Vrátil


On Dec. 9, 2014, 2:57 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121407/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2014, 2:57 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Daniel Vrátil, Laurent Montel, and Volker Krause.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> In EntityMimeTypeFilterModel::filterAcceptsRow, we can check the
> mimetype first, before checking whether the item has a payload.
> The latter requires a temporary data allocation inside QVariant
> for the Akonadi::Item, whereas the former can leverage the optimized
> QVariant code for QString, which is faster.
> 
> 
> Diffs
> -----
> 
>   akonadi/entitymimetypefiltermodel.cpp a66afd3e00a86a36cec7b8387e3058c26cd5a3d7 
> 
> Diff: https://git.reviewboard.kde.org/r/121407/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/