[Kde-pim] Review Request 119702: QML API: do not return KUrl
Kevin Krammer
krammer at kde.org
Mon Aug 11 07:26:34 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119702/#review64216
-----------------------------------------------------------
mobile/api/mail/maillistmodel.cpp
<https://git.reviewboard.kde.org/r/119702/#comment44873>
KUrl is derived from QUrl so this should work as well:
return QUrl(item.url());
- Kevin Krammer
On Aug. 10, 2014, 10:06 nachm., Michael Bohlender wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119702/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2014, 10:06 nachm.)
>
>
> Review request for KDEPIM.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> We don't want do deal with KUrl in QML so we return a QString for now. This will obviously be a QUrl once we are on Frameworks 5.
>
>
> Diffs
> -----
>
> mobile/api/mail/maillistmodel.cpp c13a0fc
>
> Diff: https://git.reviewboard.kde.org/r/119702/diff/
>
>
> Testing
> -------
>
> works with my mockups
>
>
> Thanks,
>
> Michael Bohlender
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list