[Kde-pim] Review Request 119746: Allow FavoriteCollectionsModel to be reset when Akonadi server has stopped

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119746/#review64412
-----------------------------------------------------------

Ship it!


Makes sense, ship it!

- Dan Vrátil


On Aug. 12, 2014, 11:11 p.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119746/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 11:11 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Bugs: 336942
>     http://bugs.kde.org/show_bug.cgi?id=336942
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> When the Akonadi server stops, calling FavoriteCollectionsModel::setCollections(Collection::List()) removes all collections from the model's collection list, but no collections are removed from the list of referenced collections. This is because the private dereference() function only removes them if their model index is valid. But because the server has stopped, they cannot have valid indexes.
> 
> The patch makes dereference() remove the collection from the list of referenced collections regardless of whether the collection's model index is valid. This allows FavoriteCollectionsModel to be reset completely when the server has stopped.
> 
> 
> Diffs
> -----
> 
>   akonadi/favoritecollectionsmodel.cpp 08b1975 
> 
> Diff: https://git.reviewboard.kde.org/r/119746/diff/
> 
> 
> Testing
> -------
> 
> Tested with KAlarm. This now allows alarms to be redisplayed after an Akonadi server restart.
> 
> 
> Thanks,
> 
> David Jarvie
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/