[Kde-pim] Review Request 119575: Fix krunner contacts pllugin

[Dan Vrátil]

> On Aug. 4, 2014, 8:24 a.m., Christian Mollekopf wrote:
> > runners/contacts/contactsrunner.cpp, line 80
> > <https://git.reviewboard.kde.org/r/119575/diff/3/?file=295079#file295079line80>
> >
> >     Calling exec is generally a bad idea, but I'm not sure wether you have another option with the current runner design.

It does not matter in KRunner - since each runner has it's own thread, the .exec() should not cause any harm here.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119575/#review63733
-----------------------------------------------------------


On Aug. 4, 2014, 12:40 a.m., Marc Deop wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119575/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 12:40 a.m.)
> 
> 
> Review request for KDEPIM and Plasma.
> 
> 
> Bugs: 282567
>     http://bugs.kde.org/show_bug.cgi?id=282567
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Fix krunner contacts plugin to lookup contacts through Akonadi
> 
> 
> Diffs
> -----
> 
>   runners/contacts/contactsrunner.h 9bcb40d34a40dad414ea5154b745c97c18d6d81b 
>   runners/contacts/contactsrunner.cpp 2261e3744c695d046ec95e6dd97f1ad26c800d71 
> 
> Diff: https://git.reviewboard.kde.org/r/119575/diff/
> 
> 
> Testing
> -------
> 
> Compiled, installed and tested locally
> 
> 
> Thanks,
> 
> Marc Deop
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/