[Kde-pim] Review Request 119816: cleaner dependencies for AkonadiNotes
Sandro Knauß
knauss at kolabsys.com
Mon Aug 18 17:27:24 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119816/
-----------------------------------------------------------
(Updated Aug. 18, 2014, 4:27 nachm.)
Review request for KDEPIM-Libraries.
Changes
-------
* replace KMime::HeaderParsing::parseDateTime -> QDateTime::fromString(lastmod->asUnicodeString(), Qt::RFC2822Date)
Repository: kdepimlibs
Description
-------
Cleanup and fixing AkonadiNotes to be installable:
* KF5AkonadiCore is not a package - it is called KF5Akonadi
* I see no need to import and use of KF5KIO
* Fixing installation path (Akonadi/Notes instead of Akonadi/notes)
Diffs (updated)
-----
akonadi-notes/CMakeLists.txt e975d873032f545c909dcf9fdde64223414c0da8
akonadi-notes/KF5AkonadiNotesConfig.cmake.in cae7070d6f7768b4cf649309cfe54ec25073f24e
akonadi-notes/autotests/notestest.cpp fb2542160ee73e123e1066475ec710148711cde3
akonadi-notes/src/CMakeLists.txt 1d4b6f97574faa2938b8967fe6dd3c4f173d4392
akonadi-notes/src/noteutils.cpp 2c908c9ba6c9f2cc102c4cdd5c7a949d52d56fb9
Diff: https://git.reviewboard.kde.org/r/119816/diff/
Testing
-------
fixed tests and run them.
Thanks,
Sandro Knauß
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list