[Kde-pim] Review Request 112362: Don't send ItemSearchJob queries through Akonadi

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112362/
-----------------------------------------------------------

(Updated Aug. 7, 2014, 12:18 p.m.)


Status
------

This change has been discarded.


Review request for KDEPIM-Libraries.


Repository: kdepimlibs


Description
-------

Instead of waiting for Akonadi to talk to Nepomuk and sending us matching items, we query Nepomuk from the ItemSearchJob and then use ItemFetchJob to fetch matching items from Akonadi.

This prevents blocking Akonadi session in case virtuoso goes nuts and does not respond to queries.

The only disadvantage of this approach is that we are losing support for anything else but SPARQL and Nepomuk, but we don't use anything else in KDE, so I don't know whether it's really a problem?


Diffs
-----

  akonadi/itemsearchjob.h 87d34b5 
  akonadi/itemsearchjob.cpp 175c76e 

Diff: https://git.reviewboard.kde.org/r/112362/diff/


Testing
-------


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/