[Kde-pim] Akonadi: updated coding style

[Guy Maurel]

Hello!

On Thursday, July 31, 2014 08:35:14 PM Daniel Vratil wrote:
> On Thursday 31 of July 2014 18:08:17 Kevin Ottens wrote:
> > Hello,
> > 
> > On Thursday 31 July 2014 14:06:56 Daniel Vrátil wrote:
> > > I just merged Guy's coding-style branch in Akonadi git to master, which
> > > means that in Akonadi we now follow the new KDE PIM coding style [0],
> > > like
> > > we already do in kdepimlibs/akonadi.
> > > 
> > > I want to say big thank you to Guy for his work - it's an incredible
> > > amount
> > > of code he had to go through and fix and thanks to him we now have a
> > > reasonable coding style which is also consistent with most of the KDE
> > > projects.
> > 
> > Note however that it introduced some behavior change. The patch is just
> > insanely big so it'll be hard to spot *where* it is, but I got some of my
> > tests depending on knut which started to fail after this update. See my
> > struggle there:
> > http://build.kde.org/job/zanshin_master/
> > 
> > I thought it was one of my own commits, but I finally nailed it down to
> > that coding style commit. If I revert it locally my tests pass again.
> > 
> > I found a workaround for the time being (I'll CC you Dan on it), but that
> > might require being investigated.
> 
> Yep, it looks like I screwed up something during rebase. It more or less
NO, you have not done anything wrong...

> points to a problem with collections (since some collection-related tests
> started failing in Jenkins), so that should make it a bit easier to nail
> down. I'll look into it tonight or tomorrow morning.
YES, Thanks for the workaround.

It is my error, as I introduce the change of handlertest.cpp on June 16.
It was on the coding-style branch. So we don't see the bug early enought.
Because I don't run all the tests at all the times.
I have used astyle, which don't made the difference between an hyphen and a 
minus.

I am looking for a better solution to "protect" the string X-AKAPPEND. In such 
a way astyle don't modify it the next time.

Bye
guy
> 
> Dan
> 
> > Regards.
> 
> _______________________________________________
> KDE PIM mailing list kde-pim at kde.org
> https://mail.kde.org/mailman/listinfo/kde-pim
> KDE PIM home page at http://pim.kde.org/

-- 
Guy Maurel
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/