[Kde-pim] Review Request 119418: LIST: Non-Recursive listing

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119418/#review63835
-----------------------------------------------------------

Ship it!


Just fix the coding style issues, and ship it!


server/src/handler/list.h
<https://git.reviewboard.kde.org/r/119418/#comment44485>

    No spaces in parenthesis



server/src/handler/list.h
<https://git.reviewboard.kde.org/r/119418/#comment44486>

    Remove spaces



server/tests/unittest/listhandlertest.cpp
<https://git.reviewboard.kde.org/r/119418/#comment44487>

    Wrong indentatation - here and in all scenarios below.


- Dan Vrátil


On Aug. 5, 2014, 1:18 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119418/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 1:18 a.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> CollectonReferenceTest: Fixed the tests after fixing the reference manager
> 
> This test couldn't work because the referenced state is reset after
> each scenario. I adapated the test now accordingly.
> 
> LIST: Non-recursive listing
> 
> Instead of recursively query for children,
> we query for a list of all collections we're interested in,
> and then assemble a tree.
> 
> This potentially results in a small overhead with few collections,
> but should scale much better when we have many collections while most
> are getting filtered by the initial query (i.e. disabled collections).
> 
> Additionally this patch ensures enabled collections that are nested in
> a disabled collection are correctly found.
> 
> Share DbInitializer for other tests and make use in listhandlertest.
> 
> use dbinitializer
> 
> remove the collections manually since sqlite doesn't deal with constraints.
> 
> 
> Diffs
> -----
> 
>   server/tests/unittest/dbinitializer.cpp PRE-CREATION 
>   server/tests/unittest/listhandlertest.cpp 1fbf1ad3499be776429c59de5525532ab2183bd8 
>   server/src/handler/list.h 1cae51fe97a5f08404eca8f4e2cbf1e08db0eec4 
>   server/src/handler/list.cpp 1c0a90cb5e30956ae5a891f4806188fdc6202fde 
>   server/tests/unittest/CMakeLists.txt b9744d93a3b0cb9e895141c10ddaf2703f12acf0 
>   server/tests/unittest/collectionreferencetest.cpp b52f28d77c63739fa22b99a8e4de0c38aa16ad91 
>   server/tests/unittest/dbinitializer.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119418/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/