[Kde-pim] Review Request 119816: cleaner dependencies for AkonadiNotes

[Laurent Montel]

> On août 19, 2014, 5:06 matin, Laurent Montel wrote:
> > akonadi-notes/src/noteutils.cpp, line 201
> > <https://git.reviewboard.kde.org/r/119816/diff/1-2/?file=305947#file305947line201>
> >
> >     For me parseDateTime is not equal to QString::fromString(... Qt::RFC2822Date);
> >     Regards.
> 
> Sandro Knauß wrote:
>     I think it is ok, 'cause if yo u look at the code of QDateTime https://qt.gitorious.org/qt/qtbase/source/cf32311d7473019f5c13fcc596601d84ac0987a3:src/corelib/tools/qdatetime.cpp#L181, you see they can parse
>     * "Wdy, DD Mon YYYY HH:MM:SS ±hhmm" (Wdy, being optional)
>     * "Wdy Mon DD HH:MM:SS YYYY"
>     
>     We construct in noteutils time headers of the format "Wdy, DD Mon YYYY HH:MM:SS ±hhmm" see l390
>     
>     Unfortunatelly KMime::HeaderParsing::parseDateTime is hard to understand and their are nealry no tests for it. From an overview they parse the same strings. Maybe they will differ in handling of non valid date strings. In the end, I think it is not that important 'cause we construct the date headers on our own and so it is safe to switch.

Ok if you're sure.
But create a separate review for it. It's not "cleaner dependencies for AkonadiNotes"
I want to be able to revert this part if we found a bug.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119816/#review64813
-----------------------------------------------------------


On août 18, 2014, 4:27 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119816/
> -----------------------------------------------------------
> 
> (Updated août 18, 2014, 4:27 après-midi)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Cleanup and fixing AkonadiNotes to be installable:
> * KF5AkonadiCore is not a package - it is called KF5Akonadi
> * I see no need to import and use of KF5KIO
> * Fixing installation path (Akonadi/Notes instead of Akonadi/notes)
> 
> 
> Diffs
> -----
> 
>   akonadi-notes/CMakeLists.txt e975d873032f545c909dcf9fdde64223414c0da8 
>   akonadi-notes/KF5AkonadiNotesConfig.cmake.in cae7070d6f7768b4cf649309cfe54ec25073f24e 
>   akonadi-notes/autotests/notestest.cpp fb2542160ee73e123e1066475ec710148711cde3 
>   akonadi-notes/src/CMakeLists.txt 1d4b6f97574faa2938b8967fe6dd3c4f173d4392 
>   akonadi-notes/src/noteutils.cpp 2c908c9ba6c9f2cc102c4cdd5c7a949d52d56fb9 
> 
> Diff: https://git.reviewboard.kde.org/r/119816/diff/
> 
> 
> Testing
> -------
> 
> fixed tests and run them.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/