[Kde-pim] Review Request 119776: Do not enter the test/ directories if AKONADI_BUILD_TESTS is off.

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119776/
-----------------------------------------------------------

Review request for Akonadi and Dan Vrátil.


Repository: akonadi


Description
-------

enable_testing() only determines whether a "test" target and the related
CTest files will be created. And in Akonadi's case it is actually
invoked regardless of the value of the AKONADI_BUILD_TESTS option
because Akonadi includes the CTest module, which calls enable_testing()
based on the value of another variable, BUILD_TESTING.

In any case, whether the executables and libraries that compose
Akonadi's unit tests will be built has nothing to do with
enable_testing(). To make AKONADI_BUILD_TESTS really disable the build
of the unit tests we now avoid entering the tests/ directories at all
when it is off, so that neither tests nor targets they depend on get
built.


Diffs
-----

  CMakeLists.txt 0c52009606612a70b192d3b607856b79f7da86e1 
  libs/CMakeLists.txt de6ab0d128cbf3ebfea5970a4d9481fd3c1dc82a 
  server/CMakeLists.txt e4829f3b0f5e42c70b2c6a80e23825d749ea5573 

Diff: https://git.reviewboard.kde.org/r/119776/diff/


Testing
-------

The unit tests are really not built and do not show up in make test.


Thanks,

Raphael Kubo da Costa

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/