[Kde-pim] Review Request 119598: Create notes out of mails

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119598/#review63755
-----------------------------------------------------------


there is a lot of duplicate code from TodoEdit*

could you create a abstract base and avoid to duplicate code please ?
Thanks

- Laurent Montel


On août 4, 2014, 9:46 matin, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119598/
> -----------------------------------------------------------
> 
> (Updated août 4, 2014, 9:46 matin)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Create notes out of mails like events or todos. This is different than annotation: This one creates a independent note with the mail as attachment - annotation is an annotation at the mail.
> 
> 
> Diffs
> -----
> 
>   messageviewer/CMakeLists.txt f2ed133af92327a8f3a979a3b172a52d7f5ccb9a 
>   messageviewer/job/createnotejob.h PRE-CREATION 
>   messageviewer/job/createnotejob.cpp PRE-CREATION 
>   messageviewer/tests/CMakeLists.txt 05fb29fd5eaccf0a563afc30e3b6faf2a8e4b854 
>   messageviewer/tests/noteedittest.h PRE-CREATION 
>   messageviewer/tests/noteedittest.cpp PRE-CREATION 
>   messageviewer/tests/viewertest.h 818ff59221d0da4269c55e1c9ee35514d156a131 
>   messageviewer/tests/viewertest.cpp 5856faabef2c5d10c0e893c46cef10e03d4b27a6 
>   messageviewer/viewer/viewer.h 058fc371f3fbf4aa0e2423f67c7c48feff02ce84 
>   messageviewer/viewer/viewer.cpp 1c176b23b443a726ed3b710ff1d69d096e6ecfdc 
>   messageviewer/viewer/viewer_p.h bf1d9075d1a59c1e9d2b9611fb9e07b88876312f 
>   messageviewer/viewer/viewer_p.cpp 9884c91c002c5d920035980e9031d015d2f73bd7 
>   messageviewer/widgets/noteedit.h PRE-CREATION 
>   messageviewer/widgets/noteedit.cpp PRE-CREATION 
>   messageviewer/settings/messageviewer.kcfg.cmake d88f9c5c4511a1b7b31e12e2fe02b3f212e5e769 
> 
> Diff: https://git.reviewboard.kde.org/r/119598/diff/
> 
> 
> Testing
> -------
> 
> Create & run tests.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/