[Kde-pim] Review Request 119434: Per attendee customization of email [2] - DialogInterception for IncienceChanger

[Sergio Luis Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119434/#review64106
-----------------------------------------------------------



akonadi/calendar/incidencechanger.cpp
<https://git.reviewboard.kde.org/r/119434/#comment44749>

    Can you do like:
    
    if (usesgroupware) {
    connect(...
    handlesInvitationsAfterChange()
    } else {
    handleDeleteJobResult2()
    }
    
    This will make it more clear to the reader that  handleDeleteJobResult2 is the continuation of the first function and that we only go through a detour if we're using groupware communication.
    
    (And the same for create and modify )
    
    Other than that I think the change is fine.



akonadi/calendar/incidencechanger_p.h
<https://git.reviewboard.kde.org/r/119434/#comment44748>

    does not need to be virtual


- Sergio Luis Martins


On Aug. 7, 2014, 10:43 a.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119434/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 10:43 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> To be able to customize the emails per attendee from an iTip event. The dialogs opened by IncidenceChange has to be interceptable. You can see the both changeset in the dev/individual_mail2 branch.
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/itiphandler_p.cpp db1de2f64a87765cb999da225f163d9fa41ba97e 
>   akonadi/calendar/itiphandlerhelper_p.h 6b8ee6dd0c2187077f2f964b510883ec4f4ac7ab 
>   akonadi/calendar/itiphandlerhelper_p.cpp ba7e2c25394ab918f6539c90363d9a247578431e 
>   akonadi/calendar/incidencechanger.cpp 79d0f4922c4883bc9bb73b19c8f36572af3b625e 
>   akonadi/calendar/incidencechanger_p.h eb08eb1522d116b3ac7c4a351d8c4865f1bdcf2b 
>   akonadi/calendar/incidencechanger_p.cpp 74cf138a87564e2dc4d1a8e49d45fe5ac620e2e6 
>   akonadi/calendar/itiphandler.h dcbc6b671e5c9d13e0285b7e7063d61df5780967 
>   akonadi/calendar/itiphandler.cpp a4bc9f1f12b3dcd3b89d5b6d8fb697b788629db2 
>   akonadi/calendar/itiphandler_p.h 63040b2cd4092a870e95e62312a5ff104550ed92 
> 
> Diff: https://git.reviewboard.kde.org/r/119434/diff/
> 
> 
> Testing
> -------
> 
> run multiple times kincidenceeditor and korganizer to test and run itiphelpertest and mailclienttest.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/