[Kde-pim] Review Request 119995: Coding Style for agentinstancewidgettest.cpp agentinstancewidgettest.h agenttypewidgettest.cpp agenttypewidgettest.h collectiondialog.cpp itemdumper.cpp itemdumper.h pluginloadertest.cpp selftester.cpp subscriber.cpp

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119995/#review65600
-----------------------------------------------------------



akonadi/tests/agentinstancewidgettest.h
<https://git.reviewboard.kde.org/r/119995/#comment45847>

    shouldn't that have more intentation?



akonadi/tests/agentinstancewidgettest.h
<https://git.reviewboard.kde.org/r/119995/#comment45848>

    shouldn't that have no intentation?



akonadi/tests/agentinstancewidgettest.h
<https://git.reviewboard.kde.org/r/119995/#comment45845>

    same here



akonadi/tests/agentinstancewidgettest.h
<https://git.reviewboard.kde.org/r/119995/#comment45846>

    same here?


- Kevin Krammer


On Aug. 29, 2014, 5:16 nachm., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119995/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2014, 5:16 nachm.)
> 
> 
> Review request for KDEPIM-Libraries, Dan Vrátil, Kevin Krammer, and Laurent Montel.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This is the second run.
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/tests/agentinstancewidgettest.h f27a80a 
>   akonadi/tests/agentinstancewidgettest.cpp 8040d18 
>   akonadi/tests/agenttypewidgettest.h f581e6e 
>   akonadi/tests/agenttypewidgettest.cpp 60fb35a 
>   akonadi/tests/collectiondialog.cpp 4bca8a4 
>   akonadi/tests/itemdumper.h da4fbbb 
>   akonadi/tests/itemdumper.cpp b8920d1 
>   akonadi/tests/pluginloadertest.cpp 876ca05 
>   akonadi/tests/selftester.cpp 7d50ecc 
>   akonadi/tests/subscriber.cpp b6b13f8 
> 
> Diff: https://git.reviewboard.kde.org/r/119995/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/