[Kde-pim] Review Request 112793: Add tab for adding/removing Akonadi agents to KAdressbook settings dialog

Achim Bohnet ach at mpe.mpg.de
Thu Aug 7 15:57:29 BST 2014


On Thursday 07 Aug 2014 10:20:57 Dan Vrátil wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112793/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 12:20 p.m.)
> 
> 
> Status
> ------
> 
> This change has been discarded.
Hi Dan,

Why is it discarded?  It's IMHO a useful feature and follows 'least surprise'
principle.  I stumble on this missing feature again and again ;-)

Achim
> 
> 
> Review request for KDEPIM and Tobias Koenig.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> A tab for adding Akonadi resources is in KMail, KOrganizer, Akregator and
> other Akonadi apps, so users would expect the same tab to be available in
> KAdressbook - this patch creates a new KCM module that adds "General" tab
> to KAddressbook with UI for adding, configuring and removing agents, like
> in the other mentioned apps.
> 
> 
> Diffs
> -----
> 
>   kaddressbook/CMakeLists.txt 3756e60
>   kaddressbook/config/CMakeLists.txt PRE-CREATION
>   kaddressbook/config/config_general.h PRE-CREATION
>   kaddressbook/config/config_general.cpp PRE-CREATION
>   kaddressbook/config/config_general.ui PRE-CREATION
>   kaddressbook/config/kaddressbook_config_general.desktop PRE-CREATION
>   kaddressbook/mainwidget.cpp 6141b39
> 
> Diff: https://git.reviewboard.kde.org/r/112793/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
> _______________________________________________
> KDE PIM mailing list kde-pim at kde.org
> https://mail.kde.org/mailman/listinfo/kde-pim
> KDE PIM home page at http://pim.kde.org/

-- 
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- reddy at lion.austin.ibm.com

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list