[Kde-pim] Review Request 119598: Create notes out of mails

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119598/#review64537
-----------------------------------------------------------


I didn't read all but better to move theses class to pimcommon to avoid to add a messageviewer as dependancy for korganizer.
you don't need to keep BC in kdepim
=> move it in new folder as 'pimcommon/editwidget' or other and it will be good.
=> it avoids new dependancy for korganizer.

- Laurent Montel


On août 14, 2014, 2:51 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119598/
> -----------------------------------------------------------
> 
> (Updated août 14, 2014, 2:51 après-midi)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Create notes out of mails like events or todos. This is different than annotation: This one creates a independent note with the mail as attachment - annotation is an annotation at the mail.
> 
> 
> Diffs
> -----
> 
>   messageviewer/CMakeLists.txt f2ed133af92327a8f3a979a3b172a52d7f5ccb9a 
>   messageviewer/job/createnotejob.h PRE-CREATION 
>   messageviewer/job/createnotejob.cpp PRE-CREATION 
>   messageviewer/settings/messageviewer.kcfg.cmake d88f9c5c4511a1b7b31e12e2fe02b3f212e5e769 
>   messageviewer/tests/CMakeLists.txt 05fb29fd5eaccf0a563afc30e3b6faf2a8e4b854 
>   messageviewer/tests/editwidgettest.h PRE-CREATION 
>   messageviewer/tests/editwidgettest.cpp PRE-CREATION 
>   messageviewer/tests/eventedittest.h 2dcedde448b3c474c660f89729ca284995b5e298 
>   messageviewer/tests/eventedittest.cpp 08d213436462cc05d1b2aa6dfe723751e48199f8 
>   messageviewer/tests/noteedittest.h PRE-CREATION 
>   messageviewer/tests/todoedittest.cpp 2ff44ad0849ac46b40b6fa1ce3165fc8379f960b 
>   messageviewer/tests/viewertest.h 818ff59221d0da4269c55e1c9ee35514d156a131 
>   messageviewer/tests/viewertest.cpp 5856faabef2c5d10c0e893c46cef10e03d4b27a6 
>   messageviewer/viewer/viewer.h 058fc371f3fbf4aa0e2423f67c7c48feff02ce84 
>   messageviewer/viewer/viewer.cpp 1c176b23b443a726ed3b710ff1d69d096e6ecfdc 
>   messageviewer/viewer/viewer_p.h bf1d9075d1a59c1e9d2b9611fb9e07b88876312f 
>   messageviewer/tests/noteedittest.cpp PRE-CREATION 
>   messageviewer/tests/todoedittest.h 0a03e8ee5971e85a6efc4f3f66efbfeaeebff4e3 
>   messageviewer/viewer/viewer_p.cpp 9884c91c002c5d920035980e9031d015d2f73bd7 
>   messageviewer/widgets/editwidget.h PRE-CREATION 
>   messageviewer/widgets/editwidget.cpp PRE-CREATION 
>   messageviewer/widgets/eventedit.h e5c3a74f6bdbabe453074407f7fe6032ebf829aa 
>   messageviewer/widgets/eventedit.cpp 84c70650204fc2c6df347afd9f41c8418e5cd295 
>   messageviewer/widgets/noteedit.h PRE-CREATION 
>   messageviewer/widgets/noteedit.cpp PRE-CREATION 
>   messageviewer/widgets/todoedit.h 6e4e7b917cd674cdc968f67242050879d622279b 
>   messageviewer/widgets/todoedit.cpp 3db7f8905098bf078a5721b8d6fec8c266fccb10 
> 
> Diff: https://git.reviewboard.kde.org/r/119598/diff/
> 
> 
> Testing
> -------
> 
> Create & run tests.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/