[Kde-pim] Review Request 119762: FindSqlite: Use CMAKE_FLAGS the right way in try_compile().

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119762/#review64483
-----------------------------------------------------------

Ship it!


Thanks for the patch, ship it! Just fix the comment before commiting.


cmake/modules/FindSqlite.cmake
<https://git.reviewboard.kde.org/r/119762/#comment45047>

    Put this on the same line as the CMAKE_FLAGS keyword.


- Dan Vrátil


On Aug. 13, 2014, 1:47 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119762/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 1:47 p.m.)
> 
> 
> Review request for Akonadi and Dan Vrátil.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> This fixes f90774f1 ("Check whether Sqlite is compiled with
> SQLITE_ENABLE_UNLOCK_NOTIFY"), so that SQLITE_INCLUDE_DIR is really
> passed to the try_compile() call. So far, it was just a NOP and the
> compilation only worked if sqlite3.h was in a directory the compiler
> uses automatically.
> 
> try_compile()'s syntax is a bit complicated, and CMAKE_FLAGS expects a
> series of arguments as if they had been passed to the command line, so
> instead of "CMAKE_FLAGS INCLUDE_DIRECTORIES /some/dir" one needs to use
> "CMAKE_FLAGS -DINCLUDE_DIRECTORIES:PATH=/some/dir".
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindSqlite.cmake ad8cdb4dfea9a68772751c9fafab933f4a0fe232 
> 
> Diff: https://git.reviewboard.kde.org/r/119762/diff/
> 
> 
> Testing
> -------
> 
> SQLite is properly detected when it is in /usr/local.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/