[Kde-pim] Review Request 119628: ETM: Fixed subtree algorithm in collectionsFetched.

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119628/
-----------------------------------------------------------

(Updated Aug. 6, 2014, 8:02 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries.


Repository: kdepimlibs


Description
-------

ETM: Fixed subtree algorithm in collectionsFetched.

The implemented algorithm relied on specific listing order. It had two problems:
* the subTreesToInsert were IMO never correctly built (the algorithm only works
if children come first, and then it still inserted a parent-child pair to much).
* collectionsToInsert would be overwritten with a dummy collection from the ancestor chain
unless the actual collection comes last in the list (again, depends on listing order)

With this patch the algorithm becomes order independent.

Although the original patch inserted hidden collections in case it has non-hidden
children, this patch removes this behaviour since isHidden recursively checks all ancestors.
(so this scenario shouldn't be possible).
isHidden is potentially broken though since the HIDDEN attribute is probably not
available in the ancestor chain.


Diffs
-----

  akonadi/entitytreemodel_p.cpp 3212ade37b645bd077d527b5ab421fef0f39b394 

Diff: https://git.reviewboard.kde.org/r/119628/diff/


Testing
-------


Thanks,

Christian Mollekopf

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/