[Kde-pim] Review Request 119825: Added DB Indexer and Custom DB for Events and Posts

[Martin Klapetek]

> On Aug. 20, 2014, 2:11 p.m., Laurent Montel wrote:
> > libkfapi was ported to kf5 ?
> 
> Martin Klapetek wrote:
>     No, not yet, this is supposed to be for the kde4 version of things, but given the ongoing transition, I guess it will just have to wait until all things are ready :S
> 
> Laurent Montel wrote:
>     To avoid to lose work. We can commit in kdepim-runtime. When libkfapi is ported we can adapt this code.
>     For the moment I didn't port this resources so it will not compile as previous :)
> 
> Nilesh Suthar wrote:
>     Can you guide me to with some tips to port libkfbapi, if it is the time to port now? 
>     Without porting libkfbapi how can we test this code?
> 
> Laurent Montel wrote:
>     Without porting libkfapi you can't test indeed.
>     For me you can commit you work, and after start to port libkfbapi. I don't know this lib so don't know what we need to port but I saw that it uses qjson so it needs a lot of work.
>     You can look at kdepimlibs master in each subdirectory how to adapt cmakelists.txt.
>     After that you need  to port to new qt5 json class.
> 
> Martin Klapetek wrote:
>     Then again, this is targeted for the kde4 versions, so committing to the stable branch would all work and everything will be testable.
>     
>     Is kdepim-runtime frameworks already? And is the stable version locked for new commits?
> 
> Laurent Montel wrote:
>     kde 4.14 is last version. So no new features into.
>     regards.

Alright, we'll figure out plan B then, thanks.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119825/#review64907
-----------------------------------------------------------


On Aug. 20, 2014, 7:57 p.m., Nilesh Suthar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119825/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 7:57 p.m.)
> 
> 
> Review request for KDEPIM and Martin Klapetek.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Added Custom Database need by kpeople's addressbook
> 
> 
> Diffs
> -----
> 
>   resources/facebook/facebookresource_posts.cpp d2908d2 
>   resources/facebook/CMakeLists.txt 5e076a0 
>   resources/facebook/dbindexer.h PRE-CREATION 
>   resources/facebook/dbindexer.cpp PRE-CREATION 
>   resources/facebook/facebookresource.h df69a0e 
>   resources/facebook/facebookresource_events.cpp eacff64 
>   resources/facebook/facebookresource_friends.cpp a8c5f95 
> 
> Diff: https://git.reviewboard.kde.org/r/119825/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nilesh Suthar
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/