[Kde-pim] Review Request 119788: Correctly synchronize referenced collections.

Dan Vrátil dvratil at redhat.com
Mon Aug 18 10:33:40 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119788/#review64718
-----------------------------------------------------------

Ship it!


Ship It!

- Dan Vrátil


On Aug. 14, 2014, 2:42 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119788/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 2:42 p.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> Modify: Make sure the referenced state is stored before we trigger the sync.
> 
> Otherwise it's possible that we get a LIST that expectes the referenced state,
> before it's stored. Since the changes only become visible to other sessions
> after the transaction has been comitted, I moved the transactioncommit before
> the signals are emitted.
> 
> LIST: list referenced collections to resources.
> 
> Otherwise referenced collections are never synchronized resulting in no content.
> 
> 
> Diffs
> -----
> 
>   server/src/handler/list.cpp 45d9de8c46da391485314341e599cbab0d877bd6 
>   server/src/handler/modify.cpp 096db8081e119f75f5f6e2408cdb2aee7733bd09 
> 
> Diff: https://git.reviewboard.kde.org/r/119788/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list