[Kde-pim] Review Request 119223: Fix the build of QGpgme in the frameworks branch

Laurent Montel montel at kde.org
Thu Aug 7 06:30:01 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119223/#review63959
-----------------------------------------------------------

Ship it!


I tested it and no problem.
If it fixes your problem commit it

Ship it

- Laurent Montel


On juil. 20, 2014, 7:28 matin, Cristian OneČ› wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119223/
> -----------------------------------------------------------
> 
> (Updated juil. 20, 2014, 7:28 matin)
> 
> 
> Review request for KDEPIM-Libraries and Laurent Montel.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> I'm building the frameworks branch of kdepimlibs using kdesrc-build in a custom folder. Somehow the gpgme includes which are located in '/usr/include/gpgme' do not end up on the compile command line of the QGpgme files. ${GPGME_VANILLA_LIBRARIES} in the target_link_libraries does not seem to be enough so I added ${GPGME_INCLUDES} to target_include_directories.
> 
> If this is not the correct approach fee free to discard this request.
> 
> 
> Diffs
> -----
> 
>   gpgme++/src/CMakeLists.txt 8b3316e 
> 
> Diff: https://git.reviewboard.kde.org/r/119223/diff/
> 
> 
> Testing
> -------
> 
> The build with the patch works.
> 
> 
> Thanks,
> 
> Cristian OneČ›
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list