[Kde-pim] Review Request 119765: Coding Style for itemappendtest.h itemfetchtest.h itemhydratest.h itemserializertest.h itemstoretest.h itemtest.h mimetypecheckertest.h modelspy.h monitortest.h resourceschedulertest.h searchjobtest.h test_utils.h testattribute.h transactiontest.h

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119765/#review64553
-----------------------------------------------------------



akonadi/autotests/modelspy.h
<https://git.reviewboard.kde.org/r/119765/#comment45112>

    missing the reference part of const reference. and maybe put the const first, see "parent" argument of the verifySignal methods below


- Kevin Krammer


On Aug. 14, 2014, 4:23 nachm., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119765/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 4:23 nachm.)
> 
> 
> Review request for KDEPIM-Libraries, Dan Vrátil and Kevin Krammer.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This is the second run.
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/autotests/itemappendtest.h c2a204a 
>   akonadi/autotests/itemfetchtest.h 280f1eb 
>   akonadi/autotests/itemhydratest.h 8723251 
>   akonadi/autotests/itemserializertest.h 8cbd469 
>   akonadi/autotests/itemstoretest.h 0b08707 
>   akonadi/autotests/itemtest.h b598ff2 
>   akonadi/autotests/mimetypecheckertest.h 5d4da74 
>   akonadi/autotests/modelspy.h d40879b 
>   akonadi/autotests/monitortest.h 176d723 
>   akonadi/autotests/resourceschedulertest.h 2f73f3e 
>   akonadi/autotests/searchjobtest.h 8fa650a 
>   akonadi/autotests/test_utils.h 45cf1db 
>   akonadi/autotests/testattribute.h 3cbcfee 
>   akonadi/autotests/transactiontest.h 797923e 
> 
> Diff: https://git.reviewboard.kde.org/r/119765/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/