[Kde-pim] Review Request 119694: QML API: add message status icon to the maillistmodel

Kevin Krammer krammer at kde.org
Sun Aug 10 14:24:21 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119694/#review64169
-----------------------------------------------------------



mobile/api/mail/maillistmodel.cpp
<https://git.reviewboard.kde.org/r/119694/#comment44814>

    we always use block braces on if/else and loops, even when there is only one statement


just a small style thing, otherwise looks good

- Kevin Krammer


On Aug. 10, 2014, 1:12 nachm., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119694/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2014, 1:12 nachm.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> let the model return the name of the statusIcon as a string. 
> 
> 
> Diffs
> -----
> 
>   mobile/api/mail/maillistmodel.h e3a2b27 
>   mobile/api/mail/maillistmodel.cpp 3baa8c5 
> 
> Diff: https://git.reviewboard.kde.org/r/119694/diff/
> 
> 
> Testing
> -------
> 
> works with my mockups
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list