[Kde-pim] Review Request 119810: Remove the scary hidden parameter from KMail::openComposer

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119810/#review64665
-----------------------------------------------------------


thanks! looks good to me but obviously something that needs Laurent's approval

- Kevin Krammer


On Aug. 16, 2014, 11:30 nachm., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119810/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2014, 11:30 nachm.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> The hidden parameter was only recognized, if the mail is not an iTip invitation. Actually if calling openComposer an composer should be opend. No need to habe the parameter hidden. (Created out of Review #119461)
>     
>     
> 
> 
> Diffs
> -----
> 
>   incidenceeditor-ng/opencomposerjob.cpp 052449a0d4098dd8fbd2f131bccb1ee325159670 
>   kmail/kmkernel.h 3adce85e24df44eeeec29098461782227ed4c0f0 
>   kmail/kmkernel.cpp 052359399ab5d8065977c3660080beebfc063133 
> 
> Diff: https://git.reviewboard.kde.org/r/119810/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/