[Kde-pim] Review Request 119702: QML API: do not return KUrl

[Kevin Krammer]

> On Aug. 11, 2014, 6:26 vorm., Kevin Krammer wrote:
> > mobile/api/mail/maillistmodel.cpp, line 108
> > <https://git.reviewboard.kde.org/r/119702/diff/1/?file=303688#file303688line108>
> >
> >     KUrl is derived from QUrl so this should work as well:
> >     
> >     return QUrl(item.url());

or 
return QVariant::fromValue<QUrl>(item.url());


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119702/#review64216
-----------------------------------------------------------


On Aug. 10, 2014, 10:06 nachm., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119702/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2014, 10:06 nachm.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> We don't want do deal with KUrl in QML so we return a QString for now. This will obviously be a QUrl once we are on Frameworks 5.
> 
> 
> Diffs
> -----
> 
>   mobile/api/mail/maillistmodel.cpp c13a0fc 
> 
> Diff: https://git.reviewboard.kde.org/r/119702/diff/
> 
> 
> Testing
> -------
> 
> works with my mockups
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/