[Kde-pim] Review Request 119600: Create Event/Note/Todo of of Event/Todo

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119600/#review63759
-----------------------------------------------------------



korganizer/noteeditdialog.h
<https://git.reviewboard.kde.org/r/119600/#comment44439>

    is it not possible to create it in cpp file as in messageviewer/widget/eventedit.cpp ?



korganizer/noteeditdialog.cpp
<https://git.reviewboard.kde.org/r/119600/#comment44440>

    you duplicate this code from other patch no ?
    Perhaps you can move this code in pimcommon or other no to avoid duplicate code.


- Laurent Montel


On août 4, 2014, 9:54 matin, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119600/
> -----------------------------------------------------------
> 
> (Updated août 4, 2014, 9:54 matin)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Create Event/Note/Todo of of an Event/Todo inside korganizer. Show for the new Event/Todo a IncidenceDialog and for notes a new dialog is added.
> 
> 
> Diffs
> -----
> 
>   korganizer/noteeditdialog.h PRE-CREATION 
>   korganizer/koeventpopupmenu.cpp c3a9481a4568cb5afca84477e6b3d7d75842eb55 
>   incidenceeditor-ng/incidencedialog.cpp c55db38a6d262c64d030085c1c875d3f75b2a6fe 
>   korganizer/tests/noteeditdialogtest.cpp PRE-CREATION 
>   korganizer/tests/noteeditdialogtest.h PRE-CREATION 
>   korganizer/tests/koeventpopupmenutest.cpp PRE-CREATION 
>   korganizer/tests/koeventpopupmenutest.h PRE-CREATION 
>   korganizer/tests/CMakeLists.txt d38e489641187ed6a6c4a3eeabbc3fac3bbf8b48 
>   korganizer/noteeditdialog.cpp PRE-CREATION 
>   korganizer/koeventpopupmenu.h e04f1de5df90cfb3bd22a40c463390a5ea18ce67 
>   korganizer/CMakeLists.txt dc6795830879037f393f0deadfcfa3fdc2ee05a5 
> 
> Diff: https://git.reviewboard.kde.org/r/119600/diff/
> 
> 
> Testing
> -------
> 
> wrote and run tests
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/