[Kde-pim] Review Request 120006: Coding Style for agentbase.cpp agentbase.h agentbase_p.h agentfactory.cpp agentsearchinterface_p.h preprocessorbase.h resourcebase.cpp resourcescheduler.cpp transportresourcebase.h

[Guy Maurel]

> On Aug. 31, 2014, 6:40 p.m., Kevin Krammer wrote:
> > akonadi/src/agentbase/resourcescheduler.cpp, line 391
> > <https://git.reviewboard.kde.org/r/120006/diff/1/?file=308658#file308658line391>
> >
> >     looks like one level of intentation too much

well...
The intentation is done by astyle: it is a new block.


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120006/#review65602
-----------------------------------------------------------


On Aug. 30, 2014, 6:59 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120006/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2014, 6:59 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Dan Vrátil, Kevin Krammer, and Laurent Montel.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This is the second run.
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/src/agentbase/agentbase.cpp 3c93d7a 
>   akonadi/src/agentbase/agentbase_p.h 6769eef 
>   akonadi/src/agentbase/agentbase.h 9df8b34 
>   akonadi/src/agentbase/agentfactory.cpp ab28905 
>   akonadi/src/agentbase/agentsearchinterface_p.h 4d29466 
>   akonadi/src/agentbase/preprocessorbase.h 23d3d3d 
>   akonadi/src/agentbase/resourcebase.cpp cf02383 
>   akonadi/src/agentbase/resourcescheduler.cpp 7ce09cc 
>   akonadi/src/agentbase/transportresourcebase.h 65af21d 
> 
> Diff: https://git.reviewboard.kde.org/r/120006/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/