[Kde-pim] Review Request 119614: Fix range check for non-recurring events

[Wolfgang Bauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119614/
-----------------------------------------------------------

(Updated Aug. 13, 2014, 2:27 nachm.)


Review request for KDEPIM.


Changes
-------

added unit tests


Bugs: 327256
    http://bugs.kde.org/show_bug.cgi?id=327256


Repository: kdepim


Description (updated)
-------

The check whether an event is in the selected interval (in SummaryEventInfo::eventsForRange()) is totally broken for non-recurring events.
This patch should fix it, and also add a unit test.


Diffs (updated)
-----

  kontact/plugins/korganizer/tests/summaryeventtest.h a3cbb7e 
  kontact/plugins/korganizer/tests/summaryeventtest.cpp 892da77 
  kontact/plugins/korganizer/summaryeventinfo.cpp 00c9906 

Diff: https://git.reviewboard.kde.org/r/119614/diff/


Testing (updated)
-------

Add some appointments (without recurrence) in KOrganizer, they are now shown correctly in Kontact's summary view if they are in the configured interval, and not shown if they are outside that interval.

Before, only today's events were shown (and recurrent ones), see the bug report.

Also successfully ran the added unit test, it fails with the original code.


Thanks,

Wolfgang Bauer

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/