[Kde-pim] Review Request 117875: Added handling for cutype of an Attendee

Sandro Knauß knauss at kolabsys.com
Wed Apr 30 10:44:47 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117875/
-----------------------------------------------------------

(Updated April 30, 2014, 9:44 a.m.)


Review request for KDEPIM-Libraries.


Changes
-------

Fixed issues by laurent & allen


Repository: kdepimlibs


Description
-------

RFC 5545 defines the cutype of an attendee of an event. Korganzier should support this property.
The basic class KCalCore::Attendee should have this propery.

cutype is not completly defined, only an enum is not enough.
To set x-name or iana-token the QString variant of the setter/getter is needed.

Other patches will follow, to get the support at all places.

3.2.3.  Calendar User Type

   Parameter Name:  CUTYPE

   Purpose:  To identify the type of calendar user specified by the
      property.

   Format Definition:  This property parameter is defined by the
      following notation:

       cutypeparam        = "CUTYPE" "="
                          ("INDIVIDUAL"   ; An individual
                         / "GROUP"        ; A group of individuals
                         / "RESOURCE"     ; A physical resource
                         / "ROOM"         ; A room resource
                         / "UNKNOWN"      ; Otherwise not known
                         / x-name         ; Experimental type
                         / iana-token)    ; Other IANA-registered
                                          ; type
       ; Default is INDIVIDUAL

   Description:  This parameter can be specified on properties with a
      CAL-ADDRESS value type.  The parameter identifies the type of
      calendar user specified by the property.  If not specified on a
      property that allows this parameter, the default is INDIVIDUAL.
      Applications MUST treat x-name and iana-token values they don't
      recognize the same way as they would the UNKNOWN value.

   Example:

       ATTENDEE;CUTYPE=GROUP:mailto:ietf-calsch at example.org


Diffs (updated)
-----

  kcalcore/attendee.h 226b2ac4219a3fdb32e8e4c665faa43c917f3a2c 
  kcalcore/attendee.cpp a31827c29f38120247979cbe761bfa90adfa38a1 
  kcalcore/tests/testattendee.h 35a224ffa22964aa76dffef80bd8fb10ac53d68c 
  kcalcore/tests/testattendee.cpp 3648a35e59a7d963616f35efdbe6283a73fd1906 

Diff: https://git.reviewboard.kde.org/r/117875/diff/


Testing
-------

adding tests.


Thanks,

Sandro Knauß

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list