[Kde-pim] Review Request 117853: ItemCreateJob: Explicit merge API that allows to merge by GID only.

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117853/#review56894
-----------------------------------------------------------


The new coding style dictates 4 spaces indentation, so please adapt the patch.


akonadi/itemcreatejob.h
<https://git.reviewboard.kde.org/r/117853/#comment39675>

    This whole method can die now. Users can now enable and control merging entirely by setMergeByIdentifier().



akonadi/itemcreatejob.cpp
<https://git.reviewboard.kde.org/r/117853/#comment39671>

    Not needed anymore



akonadi/itemcreatejob.cpp
<https://git.reviewboard.kde.org/r/117853/#comment39670>

    You must initialize this to NoMerge



akonadi/itemcreatejob.cpp
<https://git.reviewboard.kde.org/r/117853/#comment39673>

    This is ugly and unnecessary. Just add a space into the "GID" string above, the ImapStreamParser on the server can deal with that.


- Dan Vrátil


On April 29, 2014, 11:28 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117853/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 11:28 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> ItemCreateJob: Explicit merge API that allows to merge by GID only.
> 
> Usually we want to merge by either GID or RID and not both.
> 
> 
> Diffs
> -----
> 
>   akonadi/itemcreatejob.h b55ae3a9e77fe30fc00dd3d89920a63bec7246c8 
>   akonadi/itemcreatejob.cpp 10b978c08873a53cc480667eec99cb1518e4e34c 
> 
> Diff: https://git.reviewboard.kde.org/r/117853/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/