[Kde-pim] Review Request 117689: Netherlands: Koninginnedag is now Koningsdag

[Mark Gaiser]

> On April 25, 2014, 9:44 p.m., Allen Winter wrote:
> > looks fine. please commit to the 4.13 and master branches.

I think you missed my reply on the mailing list.

Quote:
> It's not this simple. I had a roughly similar patch.
>
> The calendar stuff is meant to work if you go back in time as well. Now if
> you go back then you suddenly see a "Koningsdag" for the years back where
> it still should be "Koninginnedag" which is not the result as it should be.
>
> So the kholidays parsing and library should be modified to allow for an
> event to end at a certain point in time. And for an event to begin from a
> certain point in time.
>
> Cool huh, changing holidays ;-)

... We need John for this.
@Thijs, could you add John Layt in this review request?


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117689/#review56576
-----------------------------------------------------------


On April 22, 2014, 4:32 p.m., Thijs Kinkhorst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117689/
> -----------------------------------------------------------
> 
> (Updated April 22, 2014, 4:32 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Bugs: 331219
>     http://bugs.kde.org/show_bug.cgi?id=331219
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Starting with 2014, Queen's Day will be King's Day and celebrated
> on the 27th of April, unless that's a Sunday, then it will be a
> Saturday.
> 
> http://nl.wikipedia.org/wiki/Koningsdag_%28Nederland%29#Datum
> http://en.wikipedia.org/wiki/Koningsdag#Willem-Alexander
> 
> 
> Diffs
> -----
> 
>   kholidays/holidays/plan1/holiday_nl_nl 3027170 
>   kholidays/holidays/plan2/holiday_nl_nl fe9f263 
>   kholidays/tests/holiday_xx_xx_Old 95e1e24 
> 
> Diff: https://git.reviewboard.kde.org/r/117689/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thijs Kinkhorst
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/