[Kde-pim] Review Request 117097: Fix: when handling quoted-printable soft-broken lines, \r\n handling was missing

[Martin Koller]

> On April 1, 2014, 1:22 p.m., Jan Kundrát wrote:
> > kabc/vcardparser/vcardparser.cpp, lines 182-183
> > <https://git.reviewboard.kde.org/r/117097/diff/1/?file=257426#file257426line182>
> >
> >     Instead of (*it).foo , you can typically use it->foo .

yes, I could. But I did it that way as it is already done in the same way a few lines above (Line 97).
I did not want to introduce a style-break.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117097/#review54777
-----------------------------------------------------------


On April 1, 2014, 7:57 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117097/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 7:57 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Bugs: 332340
>     http://bugs.kde.org/show_bug.cgi?id=332340
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> When a vcard has quoted-printable encoded lines with a soft line-break, the fetch for the next line did not handle the \r\n line handling
> as is done in the outer loop
> 
> 
> Diffs
> -----
> 
>   kabc/vcardparser/testroundtrip.qrc c4e2b7f 
>   kabc/vcardparser/vcardparser.cpp a432d1b 
> 
> Diff: https://git.reviewboard.kde.org/r/117097/diff/
> 
> 
> Testing
> -------
> 
> added a new vcard testcase
> 
> 
> File Attachments
> ----------------
> 
> vcard10.vcf
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/04/01/1c76af79-0519-4591-b242-2b18bea8cf94__vcard10.vcf
> vcard10.vcf.ref
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/04/01/415d177b-2935-4243-bd73-9bf688ffb7bc__vcard10.vcf.ref
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/