[Kde-pim] Review Request 117771: TagCreateJob/TagModifyJob: tag type support + proper REMOTEID key + only finish job once complete.

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117771/#review56555
-----------------------------------------------------------



akonadi/protocolhelper.cpp
<https://git.reviewboard.kde.org/r/117771/#comment39462>

    Are you sure? TagFetchHelper::fetchTags() on Akonadi server uses AKONADI_PARAM_REMOTEID, which is "REMOTEID", not "RID"


- Dan Vrátil


On April 25, 2014, 3:58 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117771/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 3:58 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> TagCreateJob/TagModifyJob: tag type support + proper REMOTEID key + only finish job once complete.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 79bfc66a50189ade2829b500cad3bc8b8e67d8b3 
>   akonadi/protocolhelper.cpp fe20c586eaebb114726647c5e182eae37544b82b 
>   akonadi/session_p.h 2f034ef48573699231a267c8278c1229fa44d101 
>   akonadi/tagcreatejob.cpp a9e8408f34ba88d8c99a1736c9e5b62270824005 
>   akonadi/tagmodifyjob.cpp 338c3f6e653e1d6e17057b2c4e5837e62de2741e 
>   akonadi/tests/tagtest.cpp 9b24b12772c8917c96d42a74c30ca7c2d8770347 
> 
> Diff: https://git.reviewboard.kde.org/r/117771/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/