[Kde-pim] Review Request 114304: MessageList ContentSummary: Port away from Nepomuk

Vishesh Handa me at vhanda.in
Tue Apr 15 16:21:52 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114304/
-----------------------------------------------------------

(Updated April 15, 2014, 3:21 p.m.)


Status
------

This change has been discarded.


Review request for KDEPIM.


Repository: kdepim


Description
-------

    It makes very little sense to use Nepmuk to fetch the plain text content
    of the email. Nepomuk is not meant to be a data store in the case of
    Akonadi. Do not treat it like one.
    
    Instead we fetch the data from Akonadi instead.
    
    The function only works if the item has the complete payload.


Diffs
-----

  kmail/searchdialog/kmsearchmessagemodel.cpp dfe602c 
  messagelist/core/view.cpp fa4dc46 
  messagelist/messagelistutil.h 3ff5450 
  messagelist/messagelistutil.cpp 4334a22 

Diff: https://git.reviewboard.kde.org/r/114304/diff/


Testing
-------

This currently does not work for the tooltips as the item does not have the complete payload. If this is something we can all agree on then maybe I can look into the code calling this to fetch the full payload.


Thanks,

Vishesh Handa

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list