[Kde-pim] Review Request 117853: ItemCreateJob: Explicit merge API that allows to merge by GID only.

Dan Vrátil dvratil at redhat.com
Wed Apr 30 13:06:33 BST 2014



> On April 30, 2014, 10:14 a.m., Dan Vrátil wrote:
> >

Before you ship this, please update the itemappendtest.cpp - does not compile with this revision ;-)


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117853/#review56947
-----------------------------------------------------------


On April 30, 2014, 9:35 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117853/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 9:35 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> ItemCreateJob: Explicit merge API that allows to merge by GID only.
> 
> Usually we want to merge by either GID or RID and not both.
> 
> 
> Diffs
> -----
> 
>   akonadi/itemcreatejob.h b55ae3a9e77fe30fc00dd3d89920a63bec7246c8 
>   akonadi/itemcreatejob.cpp 10b978c08873a53cc480667eec99cb1518e4e34c 
> 
> Diff: https://git.reviewboard.kde.org/r/117853/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list