[Kde-pim] Review Request 117761: Make LdapClientSearch usable for other circumstances

[Laurent Montel]

> On April 25, 2014, 9:08 a.m., Laurent Montel wrote:
> > libkdepim/ldap/ldapclientsearch.cpp, line 310
> > <https://git.reviewboard.kde.org/r/117761/diff/1/?file=268161#file268161line310>
> >
> >     why it's necessary to emit before ?
> >     What was the bug about it ?
> 
> Sandro Knauß wrote:
>     makeSearchData clears out mResults at the end (line 414) -> the signal must called before the function is called.
> 
> Laurent Montel wrote:
>     So why it was not necessary before ? in kdepim code ?
> 
> Sandro Knauß wrote:
>     I think you overseen, that I added a new signal called:
>     void searchData( const QList<KLDAP::LdapResultObject> &results );
>     
>     This new signal makes it possible to work on the "raw LDAP Objects" and make it usable in more circumstances.
>     
>     The other searchData signals are only usable, if you use this class for searching mailaddresses.

indeed I didn't see this new signal. it has the same name as other. Ok


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117761/#review56482
-----------------------------------------------------------


On April 25, 2014, 3:27 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117761/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 3:27 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> To reuse LdapClientSearch in the ResourceManager (not published yet) there are some needed changes at the LdapClientSearch interface.
> The ResourceManager will be a application to look at resources for events.
> 
> 
> Diffs
> -----
> 
>   libkdepim/addressline/addresseelineedit.cpp f9e8d88039f1cad25f8a3d469ee5328e6e1d7b74 
>   libkdepim/ldap/ldapclientsearch.h b2199720968c120b7cc23fc29e3dd8057eb01b4c 
>   libkdepim/ldap/ldapclientsearch.cpp 47e3e0957dd234e54d822e4bd8baed2412e3a13d 
> 
> Diff: https://git.reviewboard.kde.org/r/117761/diff/
> 
> 
> Testing
> -------
> 
> test addresslineedit ( that is the only found usage of LdapClientSearch) and using the ResourceManager.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/