[Kde-pim] Review Request 117237: Coding Style for job_p.h

Kevin Krammer krammer at kde.org
Sun Apr 13 19:20:46 BST 2014


--===============1780467139224772957==
Content-Type: multipart/signed; boundary="nextPart1509305.YODPYWCj5R"; micalg="pgp-sha1"; protocol="application/pgp-signature"


--nextPart1509305.YODPYWCj5R
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="us-ascii"

On Friday, 2014-04-04, 15:46:19, Guy Maurel wrote:
> > On March 31, 2014, 10:34 p.m., David Jarvie wrote:
> > > When there was a flood of coding style review requests 3 or 4 wee=
ks ago,
> > > you were requested to group multiple files into single reviews. O=
nce
> > > again, there are lots of reviews all for individual files, which
> > > creates too many emails on the list.
> As I make a review I must deal with my reviewer(s).
> Kevin and Dan wish a review per file. Please, discuss that with the
> reviewers. Thanks.

My preference is reviews I an quickly go through, i.e. each review only=
 takes=20
a couple of minutes and not half an hour.

If anyone else prefers huge reviews make sure you are actually [1]=20
volunteering to do the reviews because I won't.

Cheers,
Kevin

[1] So far I've only seen Dan doing any of these reviews=20
=2D-=20
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring

--nextPart1509305.YODPYWCj5R
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iD8DBQBTStWHnKMhG6pzZJIRAiJbAJ9vhVrPj8O5F0g2cWC+xbAmHbzm/ACfWbpP
vRSJlIdjAkeaqHW8Q0FMihM=
=om2E
-----END PGP SIGNATURE-----

--nextPart1509305.YODPYWCj5R--


--===============1780467139224772957==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--===============1780467139224772957==--




More information about the kde-pim mailing list