[Kde-pim] Review Request 117761: Make LdapClientSearch usable for other circumstances
Laurent Montel
montel at kde.org
Fri Apr 25 10:08:54 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117761/#review56482
-----------------------------------------------------------
libkdepim/addressline/addresseelineedit.cpp
<https://git.reviewboard.kde.org/r/117761/#comment39414>
You didn't copy all code from kdapclientsearch.
There is a old filter + bug report about it.
Please readd it if you move it.
libkdepim/ldap/ldapclientsearch.h
<https://git.reviewboard.kde.org/r/117761/#comment39417>
fix indent please
libkdepim/ldap/ldapclientsearch.cpp
<https://git.reviewboard.kde.org/r/117761/#comment39415>
? We never used it.
Why it's necessary to specify kolab* ?
libkdepim/ldap/ldapclientsearch.cpp
<https://git.reviewboard.kde.org/r/117761/#comment39416>
if (attrs != d->mAttributes) {
...
}
libkdepim/ldap/ldapclientsearch.cpp
<https://git.reviewboard.kde.org/r/117761/#comment39418>
why it's necessary to emit before ?
What was the bug about it ?
- Laurent Montel
On April 25, 2014, 8:09 a.m., Sandro Knauß wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117761/
> -----------------------------------------------------------
>
> (Updated April 25, 2014, 8:09 a.m.)
>
>
> Review request for KDEPIM.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> To reuse LdapClientSearch in the ResourceManager (not published yet) there are some needed changes at the LdapClientSearch interface.
> The ResourceManager will be a application to look at resources for events.
>
>
> Diffs
> -----
>
> libkdepim/addressline/addresseelineedit.cpp f9e8d88039f1cad25f8a3d469ee5328e6e1d7b74
> libkdepim/ldap/ldapclientsearch.h b2199720968c120b7cc23fc29e3dd8057eb01b4c
> libkdepim/ldap/ldapclientsearch.cpp 47e3e0957dd234e54d822e4bd8baed2412e3a13d
>
> Diff: https://git.reviewboard.kde.org/r/117761/diff/
>
>
> Testing
> -------
>
> test addresslineedit ( that is the only found usage of LdapClientSearch) and using the ResourceManager.
>
>
> Thanks,
>
> Sandro Knauß
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list