[Kde-pim] Review Request 117231: Coding Style for item.h

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117231/#review56887
-----------------------------------------------------------



akonadi/item.h
<https://git.reviewboard.kde.org/r/117231/#comment39669>

    What I meant was that the arguments should be called "ptr" in the implementation, but there should be no name in the declaration here.
    
    Please remove the "ptr" from here (and from the 2 methods below) and keep the original version (except for tryToClone(T *) const)


- Dan Vrátil


On April 23, 2014, 4:49 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117231/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 4:49 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Dan Vrátil.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This is the second run.
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/item.h 9aace94 
> 
> Diff: https://git.reviewboard.kde.org/r/117231/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/