[Kde-pim] Review Request 117673: ItemSync: Allow to disable the automatic delivery done feature

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117673/#review56113
-----------------------------------------------------------

Ship it!


Seems ok, thanks.

I think that requiring resource implementations to explicitly call deliveryDone() is a better default behavior than the "smart automagic". I added it to the Frameworks/Akonadi page.

- Dan Vrátil


On April 21, 2014, 12:52 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117673/
> -----------------------------------------------------------
> 
> (Updated April 21, 2014, 12:52 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> ItemSync: Allow to disable the automatic delivery done feature
> 
> The imap resource relies on the item sync only finishing once deliveryDone
> is called, but setTotalItems is still useful for the progress reporting,
> which only the ItemSync can accurately do. This patch allows to use
> setTotalItems for progress reporting, while disabling the behaviour that the
> ItemSync automatically finishes once sufficient items were delivered.
> 
> 
> Diffs
> -----
> 
>   akonadi/itemsync.h 8c4d9999dcfef9a166aa2a0a16f5f4e7c8228064 
>   akonadi/itemsync.cpp a358256864bd541816284f2664b7d6d2f0db5b8e 
>   akonadi/resourcebase.h 9aac7636eebb663ae1e6ac4d2416b625dc59fb7f 
>   akonadi/resourcebase.cpp 3a1567409fb46cf6f1bce5beacab59777b2e158d 
> 
> Diff: https://git.reviewboard.kde.org/r/117673/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/