[Kde-pim] Review Request 117237: Coding Style for job_p.h

Ingo Klöcker kloecker at kde.org
Mon Apr 14 19:50:51 BST 2014


--===============2050979969603512620==
Content-Type: multipart/signed; boundary="nextPart3847789.x02vKLhGcF";
	micalg=pgp-sha1; protocol="application/pgp-signature"


--nextPart3847789.x02vKLhGcF
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Sunday 13 April 2014 23:28:13 David Jarvie wrote:
> On Sun, April 13, 2014 7:20 pm, Kevin Krammer wrote:
> > On Friday, 2014-04-04, 15:46:19, Guy Maurel wrote:
> >> > On March 31, 2014, 10:34 p.m., David Jarvie wrote:
> >> > > When there was a flood of coding style review requests 3 or 4
> >> > > weeks
> >> 
> >> ago,
> >> 
> >> > > you were requested to group multiple files into single reviews.
> >> > > Once
> >> > > again, there are lots of reviews all for individual files,
> >> > > which
> >> > > creates too many emails on the list.
> >> 
> >> As I make a review I must deal with my reviewer(s).
> >> Kevin and Dan wish a review per file. Please, discuss that with the
> >> reviewers. Thanks.
> > 
> > My preference is reviews I an quickly go through, i.e. each review
> > only takes
> > a couple of minutes and not half an hour.
> > 
> > If anyone else prefers huge reviews make sure you are actually [1]
> > volunteering to do the reviews because I won't.
> 
> How about grouping the reviews into say 3 or 4 files per review? This
> would substantially reduce the traffic on the mailing list, and might
> be manageable from your point of view also?

Alternative suggestion: Everybody not interested in "Coding Style" 
"Review Request" simply filters those messages. (FWIW, I filter _all_ 
review requests because I simply lack the time acting on those.)


Regards,
Ingo

--nextPart3847789.x02vKLhGcF
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iEYEABECAAYFAlNMLi8ACgkQGnR+RTDgudjbcgCg41wRWSYb/GKEoE/v0CL7zH84
A8EAnAwaJcU+XKlICUmLHoOAp2+dtBTb
=SwJ9
-----END PGP SIGNATURE-----

--nextPart3847789.x02vKLhGcF--

--===============2050979969603512620==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--===============2050979969603512620==--



More information about the kde-pim mailing list