[Kde-pim] Review Request 117807: Simplify InstallSettings.cmake by using GNUInstallDirs

Dan Vrátil dvratil at redhat.com
Tue Apr 29 13:37:35 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117807/#review56891
-----------------------------------------------------------


This removes the entire if (WIN32) branch. Will that still work?

- Dan Vrátil


On April 27, 2014, 10:48 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117807/
> -----------------------------------------------------------
> 
> (Updated April 27, 2014, 10:48 p.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> As a nice side effect it automatically detects lib vs lib64 without having
> to pass -DLIB_SUFFIX=64 to cmake.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 39c6027d073effc016a90578516a0e1178bc5eac 
>   cmake/modules/InstallSettings.cmake b8a79bbc1423f190753efcd4b6dd35f5beadc58f 
> 
> Diff: https://git.reviewboard.kde.org/r/117807/diff/
> 
> 
> Testing
> -------
> 
> Compiles and now installs correctly into $PREFIX/lib64.
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list