[Kde-pim] Review Request 117242: Coding Style for tagattribute.h

[Kevin Krammer]

> On April 9, 2014, 8:35 a.m., Dan Vrátil wrote:
> > akonadi/tagattribute.h, line 99
> > <https://git.reviewboard.kde.org/r/117242/diff/1/?file=262117#file262117line99>
> >
> >     Argument name
> 
> Guy Maurel wrote:
>     I cannot find any proper variable name in the tagattribute.cpp file

There is no code in the cpp file because this effectively disables the copy constructor and assignment operator.
However, since we know those are the copy constructor and assignment operator, an appropriate name would be "other"


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117242/#review55259
-----------------------------------------------------------


On April 9, 2014, 5:40 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117242/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 5:40 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Dan Vrátil.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This is the second run.
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/tagattribute.h ca962ff 
> 
> Diff: https://git.reviewboard.kde.org/r/117242/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/