[Kde-pim] Review Request 117818: Send the name in the ancestor list

[Dan Vrátil]

> On April 29, 2014, 8:49 a.m., Volker Krause wrote:
> > The problem I see with this is that sometimes the displayed collection names are overwritten by an EntityDisplayAttribute, eg. commonly for top-level folders or translated special collections. With this approach you are displaying different names to the user in that case.
> > 
> > IIRC full ancestor chains are used by ETM, so this might increase memory consumption in KMail. That can probably be countered by making sure to share the same value instance instead of creating a new collection with a name every time (that's done in a few other places already).
> 
> Kevin Ottens wrote:
>     So you mean I should send the content of EntityDisplayAttribute instead if available?
>     
>     The problem I see with that is the fact that I've no way to know on the client end if that should be put in the Collection name or attribute. Or on the client side the name is supposed to be overriden by the EntityDisplayAttribute content anyway?

You should send both, first the collection name (as you do now), followed by quoted EntitiyDisplayAttribute displayName (or an empty string if the attribute is not present). 

However getting the EDA means at least one additional query per item (possibly more if longer ancestor chain is requested) and many (most?) apps won't make use of this feature (resources, anything using ETM?), so this should probably be disabled by default and sent only when explicitly requested in ItemFetchScope.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117818/#review56820
-----------------------------------------------------------


On April 28, 2014, 8:46 a.m., Kevin Ottens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117818/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 8:46 a.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil and Volker Krause.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> It's generally useful to at least have the name of the ancestors for
> user display purpose. It's kind of sad otherwise to have to fire up
> extra requests just for this very common information.
> 
> 
> Diffs
> -----
> 
>   server/src/handlerhelper.cpp 1b43c2b 
>   server/tests/unittest/handlerhelpertest.cpp 6686f9b 
> 
> Diff: https://git.reviewboard.kde.org/r/117818/diff/
> 
> 
> Testing
> -------
> 
> Unit tests pass.
> Used in production locally.
> 
> 
> Thanks,
> 
> Kevin Ottens
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/